From 47d6bb095ba5bfb119c7db6d6f6bdc326e629426 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Tue, 7 Oct 2014 16:21:17 -0400 Subject: [PATCH] fix divide-by-zero crash when a repo has less than 25 apps in it This was introduced in e4401ed22c0f65db5d4f1a1f0e1222b061e471af --- src/org/fdroid/fdroid/RepoXMLHandler.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/org/fdroid/fdroid/RepoXMLHandler.java b/src/org/fdroid/fdroid/RepoXMLHandler.java index 607d3d7f6..054a115a4 100644 --- a/src/org/fdroid/fdroid/RepoXMLHandler.java +++ b/src/org/fdroid/fdroid/RepoXMLHandler.java @@ -20,6 +20,7 @@ package org.fdroid.fdroid; import android.os.Bundle; + import org.fdroid.fdroid.data.Apk; import org.fdroid.fdroid.data.App; import org.fdroid.fdroid.data.Repo; @@ -29,7 +30,8 @@ import org.xml.sax.SAXException; import org.xml.sax.helpers.DefaultHandler; import java.text.ParseException; -import java.util.*; +import java.util.ArrayList; +import java.util.List; public class RepoXMLHandler extends DefaultHandler { @@ -279,7 +281,8 @@ public class RepoXMLHandler extends DefaultHandler { } else if (localName.equals("application") && curapp == null) { curapp = new App(); curapp.id = attributes.getValue("", "id"); - if (progressCounter % (totalAppCount / 25) == 0) { + /* show progress for the first 25, then start skipping every 25 */ + if (totalAppCount < 25 || progressCounter % (totalAppCount / 25) == 0) { Bundle data = new Bundle(1); data.putString(RepoUpdater.PROGRESS_DATA_REPO_ADDRESS, repo.address); progressListener.onProgress(