From 4595517aba7c0cf5e3e74c0fe9e86841134b2bd7 Mon Sep 17 00:00:00 2001 From: Marcus Hoffmann Date: Thu, 19 Jul 2018 17:23:11 +0200 Subject: [PATCH] AppProvider: fix IconUpdateQuery The query was trying to figure out some thing about suggestedVercode which shouldn't at all be necessary for setting the iconUrl. The index already contains the icon pointing to the suggested version by that repository, so we just take that regardless. --- app/src/main/java/org/fdroid/fdroid/data/AppProvider.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/data/AppProvider.java b/app/src/main/java/org/fdroid/fdroid/data/AppProvider.java index 588c3f698..1bae7e858 100644 --- a/app/src/main/java/org/fdroid/fdroid/data/AppProvider.java +++ b/app/src/main/java/org/fdroid/fdroid/data/AppProvider.java @@ -1233,12 +1233,7 @@ public class AppProvider extends FDroidProvider { app + "." + Cols.ICON + ") " + " FROM " + - apk + - " JOIN " + repo + " ON (" + repo + "." + RepoTable.Cols._ID + " = " + apk + "." + ApkTable.Cols.REPO_ID + ") " + - " WHERE " + - app + "." + Cols.ROW_ID + " = " + apk + "." + ApkTable.Cols.APP_ID + " AND " + - apk + "." + ApkTable.Cols.VERSION_CODE + " = " + app + "." + Cols.SUGGESTED_VERSION_CODE; - + repo + " WHERE " + repo + "." + RepoTable.Cols._ID + " = " + app + "." + Cols.REPO_ID; return "UPDATE " + app + " SET " + Cols.ICON_URL + " = ( " + iconUrlQuery + " )"; }