Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

init suggestedVersionCode to Integer.MIN_VALUE

Browse Source 
Java inits ints to 0.  Since it is valid to have a negative Version Code,
versionCodes are inited to Integer.MIN_VALUE;

https://docs.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html

closes #1063
This commit is contained in:
Hans-Christoph Steiner 2020-01-10 17:18:28 +01:00
parent 765f6b840f
commit 3f64fd4930
No known key found for this signature in database
GPG Key ID: 3E177817BA1B9BFA
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/java/org/fdroid/fdroid/data/App.java
View File

@ -170,11 +170,13 @@ public class App extends ValueObject implements Comparable<App>, Parcelable {
public String suggestedVersionName; public String suggestedVersionName;
/** /**
* This matches {@code CurrentVersionCode} in build metadata files. * This matches {@code CurrentVersionCode} in build metadata files. Java
* inits {@code int}s to 0. Since it is valid to have a negative Version
* Code, this is inited to {@link Integer#MIN_VALUE};
* *
* @see <a href="https://f-droid.org/docs/Build_Metadata_Reference/#CurrentVersionCode">CurrentVersionCode</a> * @see <a href="https://f-droid.org/docs/Build_Metadata_Reference/#CurrentVersionCode">CurrentVersionCode</a>
*/ */
public int suggestedVersionCode; public int suggestedVersionCode = Integer.MIN_VALUE;
/** /**
* Unlike other public fields, this is only accessible via a getter, to * Unlike other public fields, this is only accessible via a getter, to
@ -187,6 +189,7 @@ public class App extends ValueObject implements Comparable<App>, Parcelable {
/** /**
* The version that will be automatically installed if the user does not * The version that will be automatically installed if the user does not
* choose a specific version. * choose a specific version.
* TODO this should probably be converted to init to {@link Integer#MIN_VALUE} like {@link #suggestedVersionCode}
*/ */
public int autoInstallVersionCode; public int autoInstallVersionCode;