Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'issue-1172--file-not-found-in-cache' into 'master'

Browse Source 
Be more defensive when checking cached downloads.

Closes #1172

See merge request fdroid/fdroidclient!585
This commit is contained in:
Peter Serwylo 2017-09-28 02:49:13 +00:00
commit 314e55057f
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
app/src/main/java/org/fdroid/fdroid/AppUpdateStatusService.java
View File

@ -85,6 +85,22 @@ public class AppUpdateStatusService extends IntentService {
@Nullable
private Apk processDownloadedApk(File apkPath) {
Utils.debugLog(TAG, "Checking " + apkPath);
// Overly defensive checking for existence. One would think that the file exists at this point,
// because we got it from the result of File#list() earlier. However, this has proven to not be
// sufficient, and by the time we get here we are often hitting a non-existent file.
// This may be due to the fact that the loop checking each file in the cache takes a long time to execute.
// If the number of apps in the cache is large, it can take 10s of seconds to complete. In such
// cases, it is possible that Android has cleared up some files in the cache to make space in
// the meantime.
//
// This is all just a hypothesis about what may have caused
// https://gitlab.com/fdroid/fdroidclient/issues/1172
if (!apkPath.exists()) {
Log.i(TAG, "Was going to check " + apkPath + ", but it has since been removed from the cache.");
return null;
}
PackageInfo downloadedInfo = getPackageManager().getPackageArchiveInfo(apkPath.getAbsolutePath(), PackageManager.GET_GIDS);
if (downloadedInfo == null) {
Log.i(TAG, "Skipping " + apkPath + " because PackageManager was unable to read it.");