From 65e2931fe8c7892b1ddd17f813ff6ffced5cb093 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Thu, 12 May 2016 10:40:12 +0100
Subject: [PATCH 1/2] PMD: Enable UnnecessaryWrapperObjectCreation

---
 .../java/org/fdroid/fdroid/localrepo/LocalRepoManager.java    | 4 +++-
 config/pmd/rules.xml                                          | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java b/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java
index dd358f00b..faccfd992 100644
--- a/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java
+++ b/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java
@@ -372,7 +372,9 @@ public final class LocalRepoManager {
             SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
 
             // max age is an EditTextPreference, which is always a String
-            int repoMaxAge = Float.valueOf(prefs.getString("max_repo_age_days", DEFAULT_REPO_MAX_AGE_DAYS)).intValue();
+            // TODO: This pref is probably never being set. Also, why
+            // are we mixing floats and ints?
+            int repoMaxAge = Float.valueOf(prefs.getString("max_repo_age_days", DEFAULT_REPO_MAX_AGE_DAYS)).intValue(); // NOPMD
 
             serializer.startTag("", "repo");
 
diff --git a/config/pmd/rules.xml b/config/pmd/rules.xml
index 6ad35b90e..1ca6078d2 100644
--- a/config/pmd/rules.xml
+++ b/config/pmd/rules.xml
@@ -20,6 +20,7 @@
     <rule ref="rulesets/java/optimizations.xml/PrematureDeclaration"/>
     <rule ref="rulesets/java/optimizations.xml/AddEmptyString"/>
     <rule ref="rulesets/java/optimizations.xml/UseArraysAsList"/>
+    <rule ref="rulesets/java/optimizations.xml/UnnecessaryWrapperObjectCreation"/>
 
     <rule ref="rulesets/java/controversial.xml/UnnecessaryConstructor"/>
     <rule ref="rulesets/java/controversial.xml/UnnecessaryParentheses"/>

From c432bf1ea0b6e554248ad7038a604d7a3d4744c6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Thu, 12 May 2016 10:50:12 +0100
Subject: [PATCH 2/2] PMD: Enable most empty code rules

---
 .../java/org/fdroid/fdroid/views/swap/SwapAppsView.java     | 6 ++++--
 config/pmd/rules.xml                                        | 4 ++++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/views/swap/SwapAppsView.java b/app/src/main/java/org/fdroid/fdroid/views/swap/SwapAppsView.java
index d7b42505d..dd360fcb7 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/swap/SwapAppsView.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/swap/SwapAppsView.java
@@ -96,10 +96,12 @@ public class SwapAppsView extends ListView implements
         super.onFinishInflate();
         repo = getActivity().getState().getPeerRepo();
 
+        /*
         if (repo == null) {
-            // TODO: Uh oh, something stuffed up for this to happen.
-            // TODO: What is the best course of action from here?
+            TODO: Uh oh, something stuffed up for this to happen.
+            TODO: What is the best course of action from here?
         }
+        */
 
         adapter = new AppListAdapter(getContext(), getContext().getContentResolver().query(
                 AppProvider.getRepoUri(repo), AppProvider.DataColumns.ALL, null, null, null));
diff --git a/config/pmd/rules.xml b/config/pmd/rules.xml
index 1ca6078d2..3e4600f4e 100644
--- a/config/pmd/rules.xml
+++ b/config/pmd/rules.xml
@@ -17,6 +17,10 @@
     <rule ref="rulesets/java/unnecessary.xml">
         <exclude name="UselessParentheses"/> <!--Too nitpicky-->
     </rule>
+    <rule ref="rulesets/java/empty.xml">
+        <exclude name="EmptyCatchBlock"/> <!--Ignoring an exception-->
+        <exclude name="EmptyWhileStmt"/> <!--Can be useful sometimes-->
+    </rule>
     <rule ref="rulesets/java/optimizations.xml/PrematureDeclaration"/>
     <rule ref="rulesets/java/optimizations.xml/AddEmptyString"/>
     <rule ref="rulesets/java/optimizations.xml/UseArraysAsList"/>