From 2dc689e2a1601d9566c6e9e5ca183a6e7300c511 Mon Sep 17 00:00:00 2001 From: relan Date: Fri, 17 Jul 2015 09:59:34 +0300 Subject: [PATCH] Remove icons from dialogs titles Dialogs should not have icons in their title bars. See the Material Design spec: http://www.google.com/design/spec/components/dialogs.html --- F-Droid/src/org/fdroid/fdroid/FDroid.java | 2 -- F-Droid/src/org/fdroid/fdroid/views/ManageReposActivity.java | 2 -- .../org/fdroid/fdroid/views/fragments/RepoDetailsFragment.java | 1 - 3 files changed, 5 deletions(-) diff --git a/F-Droid/src/org/fdroid/fdroid/FDroid.java b/F-Droid/src/org/fdroid/fdroid/FDroid.java index 0e194f616..e1fcea10d 100644 --- a/F-Droid/src/org/fdroid/fdroid/FDroid.java +++ b/F-Droid/src/org/fdroid/fdroid/FDroid.java @@ -309,7 +309,6 @@ public class FDroid extends ActionBarActivity { ).setView(view); } final AlertDialog alrt = builder.create(); - alrt.setIcon(R.drawable.ic_launcher); alrt.setTitle(getString(R.string.about_title)); alrt.setButton(AlertDialog.BUTTON_NEUTRAL, getString(R.string.about_website), @@ -342,7 +341,6 @@ public class FDroid extends ActionBarActivity { if (data != null && data.hasExtra(ManageReposActivity.REQUEST_UPDATE)) { AlertDialog.Builder ask_alrt = new AlertDialog.Builder(this); ask_alrt.setTitle(getString(R.string.repo_update_title)); - ask_alrt.setIcon(android.R.drawable.ic_menu_rotate); ask_alrt.setMessage(getString(R.string.repo_alrt)); ask_alrt.setPositiveButton(getString(R.string.yes), new DialogInterface.OnClickListener() { diff --git a/F-Droid/src/org/fdroid/fdroid/views/ManageReposActivity.java b/F-Droid/src/org/fdroid/fdroid/views/ManageReposActivity.java index 198963a0b..1b2af6c3d 100644 --- a/F-Droid/src/org/fdroid/fdroid/views/ManageReposActivity.java +++ b/F-Droid/src/org/fdroid/fdroid/views/ManageReposActivity.java @@ -348,9 +348,7 @@ public class ManageReposActivity extends ActionBarActivity { final EditText uriEditText = (EditText) view.findViewById(R.id.edit_uri); final EditText fingerprintEditText = (EditText) view.findViewById(R.id.edit_fingerprint); - addRepoDialog.setIcon(android.R.drawable.ic_menu_add); addRepoDialog.setTitle(getString(R.string.repo_add_title)); - addRepoDialog.setButton(DialogInterface.BUTTON_NEGATIVE, getString(R.string.cancel), new DialogInterface.OnClickListener() { diff --git a/F-Droid/src/org/fdroid/fdroid/views/fragments/RepoDetailsFragment.java b/F-Droid/src/org/fdroid/fdroid/views/fragments/RepoDetailsFragment.java index 19f8990a7..630fee3e0 100644 --- a/F-Droid/src/org/fdroid/fdroid/views/fragments/RepoDetailsFragment.java +++ b/F-Droid/src/org/fdroid/fdroid/views/fragments/RepoDetailsFragment.java @@ -340,7 +340,6 @@ public class RepoDetailsFragment extends Fragment { private void promptForDelete() { new AlertDialog.Builder(getActivity()) .setTitle(R.string.repo_confirm_delete_title) - .setIcon(android.R.drawable.ic_menu_delete) .setMessage(R.string.repo_confirm_delete_body) .setPositiveButton(android.R.string.ok, new DialogInterface.OnClickListener() { @Override