diff --git a/app/src/main/java/org/fdroid/fdroid/privileged/views/AppSecurityPermissions.java b/app/src/main/java/org/fdroid/fdroid/privileged/views/AppSecurityPermissions.java
index 3bd77bb95..0ed396be5 100644
--- a/app/src/main/java/org/fdroid/fdroid/privileged/views/AppSecurityPermissions.java
+++ b/app/src/main/java/org/fdroid/fdroid/privileged/views/AppSecurityPermissions.java
@@ -60,9 +60,7 @@ import java.util.Set;
* extended information consisting of all groups and permissions.
* To use this view define a LinearLayout or any ViewGroup and add this
* view by instantiating AppSecurityPermissions and invoking getPermissionsView.
- */
-
-/**
+ *
* NOTES:
* Based on AOSP core/java/android/widget/AppSecurityPermissions
* latest included commit: a3f68ef2f6811cf72f1282214c0883db5a30901d
diff --git a/app/src/main/java/org/fdroid/fdroid/privileged/views/InstallConfirmActivity.java b/app/src/main/java/org/fdroid/fdroid/privileged/views/InstallConfirmActivity.java
index a9af419b3..434abe3bc 100644
--- a/app/src/main/java/org/fdroid/fdroid/privileged/views/InstallConfirmActivity.java
+++ b/app/src/main/java/org/fdroid/fdroid/privileged/views/InstallConfirmActivity.java
@@ -41,6 +41,11 @@ import android.widget.TextView;
import org.fdroid.fdroid.FDroidApp;
import org.fdroid.fdroid.R;
+/**
+ * NOTES:
+ * Parts are based on AOSP src/com/android/packageinstaller/PackageInstallerActivity.java
+ * latest included commit: c23d802958158d522e7350321ad9ac6d43013883
+ */
public class InstallConfirmActivity extends Activity implements OnCancelListener, OnClickListener {
public static final int RESULT_CANNOT_PARSE = RESULT_FIRST_USER + 1;
@@ -107,9 +112,8 @@ public class InstallConfirmActivity extends Activity implements OnCancelListener
findViewById(R.id.tabscontainer).setVisibility(View.GONE);
findViewById(R.id.divider).setVisibility(View.VISIBLE);
}
- final int np = perms.getPermissionCount(AppSecurityPermissions.WHICH_PERSONAL);
- final int nd = perms.getPermissionCount(AppSecurityPermissions.WHICH_DEVICE);
- if (np > 0 || nd > 0) {
+ final int N = perms.getPermissionCount(AppSecurityPermissions.WHICH_ALL);
+ if (N > 0) {
permVisible = true;
LayoutInflater inflater = (LayoutInflater) getSystemService(
Context.LAYOUT_INFLATER_SERVICE);
@@ -117,18 +121,8 @@ public class InstallConfirmActivity extends Activity implements OnCancelListener
if (mScrollView == null) {
mScrollView = (CaffeinatedScrollView) root.findViewById(R.id.scrollview);
}
- final ViewGroup privacyList = (ViewGroup) root.findViewById(R.id.privacylist);
- if (np > 0) {
- privacyList.addView(perms.getPermissionsView(AppSecurityPermissions.WHICH_PERSONAL));
- } else {
- privacyList.setVisibility(View.GONE);
- }
- final ViewGroup deviceList = (ViewGroup) root.findViewById(R.id.devicelist);
- if (nd > 0) {
- deviceList.addView(perms.getPermissionsView(AppSecurityPermissions.WHICH_DEVICE));
- } else {
- root.findViewById(R.id.devicelist).setVisibility(View.GONE);
- }
+ final ViewGroup permList = (ViewGroup) root.findViewById(R.id.permission_list);
+ permList.addView(perms.getPermissionsView(AppSecurityPermissions.WHICH_ALL));
adapter.addTab(tabHost.newTabSpec(TAB_ID_ALL).setIndicator(
getText(R.string.allPerms)), root);
}
diff --git a/app/src/main/res/drawable/ic_perm_device_info.xml b/app/src/main/res/drawable/ic_perm_device_info.xml
new file mode 100644
index 000000000..a0570f228
--- /dev/null
+++ b/app/src/main/res/drawable/ic_perm_device_info.xml
@@ -0,0 +1,21 @@
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layout/permissions_list.xml b/app/src/main/res/layout/permissions_list.xml
index 12ac0b527..b6affc630 100644
--- a/app/src/main/res/layout/permissions_list.xml
+++ b/app/src/main/res/layout/permissions_list.xml
@@ -1,5 +1,4 @@
-
-
-
+
-
-
-
-
-
-
-
-
+ android:layout_height="wrap_content"
+ android:orientation="vertical"
+ android:paddingEnd="4dp"
+ android:paddingRight="4dp"
+ tools:ignore="RtlSymmetry" />
+
\ No newline at end of file
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 2b2cb2c8b..1d8062f77 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -361,8 +361,6 @@
be lost. It does not require any special access.
New
All
- Privacy
- Device Access
This may cost you money
Do you want to replace this app with the factory version?
Do you want to uninstall this app?