From 28b7d69e6038586e595b014fad34c6bc134c3ccd Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Mon, 12 Jun 2017 21:31:47 +1000 Subject: [PATCH] Don't show versions with a different sig if installed. This should probably be done on the database level, if purely for the fact that we have a good set of unit tests for that. However it is still quite clean to do so here. --- .../fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java index 491e53d24..d4061d835 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java +++ b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java @@ -114,7 +114,9 @@ public class AppDetailsRecyclerViewAdapter versions = new ArrayList<>(); final List apks = ApkProvider.Helper.findByPackageName(context, this.app.packageName); for (final Apk apk : apks) { - if (apk.compatible || Preferences.get().showIncompatibleVersions()) { + boolean allowByCompatability = apk.compatible || Preferences.get().showIncompatibleVersions(); + boolean allowBySig = this.app.installedSig == null || TextUtils.equals(this.app.installedSig, apk.sig); + if (allowByCompatability && allowBySig) { versions.add(apk); } }