diff --git a/app/src/full/java/org/fdroid/fdroid/localrepo/peers/BluetoothPeer.java b/app/src/full/java/org/fdroid/fdroid/localrepo/peers/BluetoothPeer.java index 5cc75f8b8..c1a2c1a9b 100644 --- a/app/src/full/java/org/fdroid/fdroid/localrepo/peers/BluetoothPeer.java +++ b/app/src/full/java/org/fdroid/fdroid/localrepo/peers/BluetoothPeer.java @@ -2,7 +2,7 @@ package org.fdroid.fdroid.localrepo.peers; import android.bluetooth.BluetoothDevice; import android.os.Parcel; - +import android.text.TextUtils; import org.fdroid.fdroid.R; import org.fdroid.fdroid.localrepo.type.BluetoothSwap; @@ -31,9 +31,8 @@ public class BluetoothPeer implements Peer { @Override public boolean equals(Object peer) { - return peer != null - && peer instanceof BluetoothPeer - && ((BluetoothPeer) peer).device.getAddress().equals(device.getAddress()); + return peer instanceof BluetoothPeer + && TextUtils.equals(((BluetoothPeer) peer).device.getAddress(), device.getAddress()); } @Override @@ -48,7 +47,7 @@ public class BluetoothPeer implements Peer { /** * Return the fingerprint of the signing key, or {@code null} if it is not set. - * + *

* This is not yet stored for Bluetooth connections. Once a device is connected to a bluetooth * socket, if we trust it enough to accept a fingerprint from it somehow, then we may as well * trust it enough to receive an index from it that contains a fingerprint we can use. diff --git a/app/src/full/java/org/fdroid/fdroid/localrepo/peers/BonjourPeer.java b/app/src/full/java/org/fdroid/fdroid/localrepo/peers/BonjourPeer.java index 0552ebf67..3c25169a9 100644 --- a/app/src/full/java/org/fdroid/fdroid/localrepo/peers/BonjourPeer.java +++ b/app/src/full/java/org/fdroid/fdroid/localrepo/peers/BonjourPeer.java @@ -2,6 +2,7 @@ package org.fdroid.fdroid.localrepo.peers; import android.net.Uri; import android.os.Parcel; +import android.text.TextUtils; import javax.jmdns.ServiceInfo; import javax.jmdns.impl.FDroidServiceInfo; @@ -29,9 +30,9 @@ public class BonjourPeer extends WifiPeer { @Override public boolean equals(Object peer) { - if (peer != null && peer instanceof BonjourPeer) { + if (peer instanceof BonjourPeer) { BonjourPeer that = (BonjourPeer) peer; - return this.getFingerprint().equals(that.getFingerprint()); + return TextUtils.equals(this.getFingerprint(), that.getFingerprint()); } return false; }