Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use View.GONE instead of setText("")

Browse Source
This commit is contained in:
Daniel Martí 2014-01-10 22:52:35 +01:00
parent 3567d9e113
commit 27452ac31b
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/org/fdroid/fdroid/AppDetails.java
View File

@ -162,7 +162,7 @@ public class AppDetails extends ListActivity {
holder.version.setText(getString(R.string.version) holder.version.setText(getString(R.string.version)
+ " " + apk.version + " " + apk.version
+ (apk == app.curApk ? " ☆" : "")); + (apk == app.curApk ? " ☆" : ""));
if (apk.vercode == app.installedVerCode if (apk.vercode == app.installedVerCode
&& apk.sig.equals(mInstalledSigID)) { && apk.sig.equals(mInstalledSigID)) {
@ -173,14 +173,14 @@ public class AppDetails extends ListActivity {
if (apk.detail_size > 0) { if (apk.detail_size > 0) {
holder.size.setText(Utils.getFriendlySize(apk.detail_size)); holder.size.setText(Utils.getFriendlySize(apk.detail_size));
holder.size.setVisibility(View.VISIBLE);
} else { } else {
holder.size.setText(""); holder.size.setVisibility(View.GONE);
} }
if (apk.minSdkVersion > 0) { if (apk.minSdkVersion > 0) {
holder.api.setText(getString(R.string.minsdk_or_later, holder.api.setText(getString(R.string.minsdk_or_later,
Utils.getAndroidVersionName(apk.minSdkVersion))); Utils.getAndroidVersionName(apk.minSdkVersion)));
holder.api.setEnabled(apk.compatible);
holder.api.setVisibility(View.VISIBLE); holder.api.setVisibility(View.VISIBLE);
} else { } else {
holder.api.setVisibility(View.GONE); holder.api.setVisibility(View.GONE);
@ -195,14 +195,16 @@ public class AppDetails extends ListActivity {
if (apk.added != null) { if (apk.added != null) {
holder.added.setText(getString(R.string.added_on, holder.added.setText(getString(R.string.added_on,
df.format(apk.added))); df.format(apk.added)));
holder.added.setVisibility(View.VISIBLE);
} else { } else {
holder.added.setText(""); holder.added.setVisibility(View.GONE);
} }
if (pref_expert && apk.nativecode != null) { if (pref_expert && apk.nativecode != null) {
holder.nativecode.setText(apk.nativecode.toString().replaceAll(","," ")); holder.nativecode.setText(apk.nativecode.toString().replaceAll(","," "));
holder.nativecode.setVisibility(View.VISIBLE);
} else { } else {
holder.nativecode.setText(""); holder.nativecode.setVisibility(View.GONE);
} }
// Disable it all if it isn't compatible... // Disable it all if it isn't compatible...