Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

debounce incoming "WiFi Connected" events for reliable status

Browse Source 
Some devices send multiple copies of given events, like a Moto G often
sends three {@code CONNECTED} events.  So they have to be debounced to
keep the {@link #BROADCAST} useful.
This commit is contained in:
Hans-Christoph Steiner 2018-04-18 16:58:51 +02:00
parent 045fc1a35e
commit 2615c461f2
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
app/src/main/java/org/fdroid/fdroid/net/WifiStateChangeService.java
View File

@ -41,6 +41,10 @@ import java.util.Locale;
* the current state because it means that something about the wifi has * the current state because it means that something about the wifi has
* changed. Having the {@code Thread} also makes it easy to kill work * changed. Having the {@code Thread} also makes it easy to kill work
* that is in progress. * that is in progress.
* <p>
* Some devices send multiple copies of given events, like a Moto G often
* sends three {@code CONNECTED} events. So they have to be debounced to
* keep the {@link #BROADCAST} useful.
*/ */
@SuppressWarnings("LineLength") @SuppressWarnings("LineLength")
public class WifiStateChangeService extends IntentService { public class WifiStateChangeService extends IntentService {
@ -50,6 +54,7 @@ public class WifiStateChangeService extends IntentService {
private WifiManager wifiManager; private WifiManager wifiManager;
private static WifiInfoThread wifiInfoThread; private static WifiInfoThread wifiInfoThread;
private static int previousWifiState = Integer.MIN_VALUE;
public WifiStateChangeService() { public WifiStateChangeService() {
super("WifiStateChangeService"); super("WifiStateChangeService");
@ -70,16 +75,17 @@ public class WifiStateChangeService extends IntentService {
Utils.debugLog(TAG, "received null Intent, ignoring"); Utils.debugLog(TAG, "received null Intent, ignoring");
return; return;
} }
Utils.debugLog(TAG, "WiFi change service started, clearing info about wifi state until we have figured it out again."); Utils.debugLog(TAG, "WiFi change service started.");
NetworkInfo ni = intent.getParcelableExtra(WifiManager.EXTRA_NETWORK_INFO); NetworkInfo ni = intent.getParcelableExtra(WifiManager.EXTRA_NETWORK_INFO);
wifiManager = (WifiManager) getApplicationContext().getSystemService(WIFI_SERVICE); wifiManager = (WifiManager) getApplicationContext().getSystemService(WIFI_SERVICE);
int wifiState = wifiManager.getWifiState(); int wifiState = wifiManager.getWifiState();
if (ni == null || ni.isConnected()) { if (ni == null || ni.isConnected()) {
Utils.debugLog(TAG, "ni == " + ni + " wifiState == " + printWifiState(wifiState)); Utils.debugLog(TAG, "ni == " + ni + " wifiState == " + printWifiState(wifiState));
if (wifiState == WifiManager.WIFI_STATE_ENABLED if (previousWifiState != wifiState &&
|| wifiState == WifiManager.WIFI_STATE_DISABLING // might be switching to hotspot (wifiState == WifiManager.WIFI_STATE_ENABLED
|| wifiState == WifiManager.WIFI_STATE_DISABLED // might be hotspot || wifiState == WifiManager.WIFI_STATE_DISABLING // might be switching to hotspot
|| wifiState == WifiManager.WIFI_STATE_UNKNOWN) { // might be hotspot || wifiState == WifiManager.WIFI_STATE_DISABLED // might be hotspot
|| wifiState == WifiManager.WIFI_STATE_UNKNOWN)) { // might be hotspot
if (wifiInfoThread != null) { if (wifiInfoThread != null) {
wifiInfoThread.interrupt(); wifiInfoThread.interrupt();
} }
@ -287,7 +293,10 @@ public class WifiStateChangeService extends IntentService {
return "WIFI_STATE_ENABLED"; return "WIFI_STATE_ENABLED";
case WifiManager.WIFI_STATE_UNKNOWN: case WifiManager.WIFI_STATE_UNKNOWN:
return "WIFI_STATE_UNKNOWN"; return "WIFI_STATE_UNKNOWN";
case Integer.MIN_VALUE:
return "previous value unset";
default:
return "~not mapped~";
} }
return null;
} }
} }