From 23dad31426f24c19229f6f524eefe16f670d5d19 Mon Sep 17 00:00:00 2001
From: Hans-Christoph Steiner <hans@eds.org>
Date: Wed, 11 May 2016 16:40:59 +0200
Subject: [PATCH] make AndroidXMLDecompress a little less kludgey

#623 https://gitlab.com/fdroid/fdroidclient/issues/623
---
 .../main/java/org/fdroid/fdroid/AndroidXMLDecompress.java    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/AndroidXMLDecompress.java b/app/src/main/java/org/fdroid/fdroid/AndroidXMLDecompress.java
index 86ed380d3..7391c1dd0 100644
--- a/app/src/main/java/org/fdroid/fdroid/AndroidXMLDecompress.java
+++ b/app/src/main/java/org/fdroid/fdroid/AndroidXMLDecompress.java
@@ -89,7 +89,8 @@ public class AndroidXMLDecompress {
         }
         int offset = xmlTagOffset;
 
-        while (offset < binaryXml.length) {
+        // we only need the first <manifest> start tag
+        if (offset < binaryXml.length) {
             int tag0 = littleEndianWord(binaryXml, offset);
 
             if (tag0 == START_TAG) {
@@ -114,8 +115,6 @@ public class AndroidXMLDecompress {
                 }
                 return attributes;
             }
-            // we only need the first <manifest> start tag
-            break;
         }
         return new HashMap<>(0);
     }