From 2067f15b27a66cc192bcff7583489797df12a84c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Tue, 8 Dec 2015 15:24:51 +0100
Subject: [PATCH] Replace some lists with counters

These objects/strings were probably useful at some point. They no longer
are.
---
 .../src/org/fdroid/fdroid/UpdateService.java   | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/F-Droid/src/org/fdroid/fdroid/UpdateService.java b/F-Droid/src/org/fdroid/fdroid/UpdateService.java
index 7e7d993c6..b8f00f4b5 100644
--- a/F-Droid/src/org/fdroid/fdroid/UpdateService.java
+++ b/F-Droid/src/org/fdroid/fdroid/UpdateService.java
@@ -351,9 +351,9 @@ public class UpdateService extends IntentService implements ProgressListener {
             List<Repo> repos = RepoProvider.Helper.all(this);
 
             //List<Repo> swapRepos = new ArrayList<>();
-            List<Repo> unchangedRepos = new ArrayList<>();
-            List<Repo> updatedRepos = new ArrayList<>();
-            List<CharSequence> errorRepos = new ArrayList<>();
+            int unchangedRepos = 0;
+            int updatedRepos = 0;
+            int errorRepos = 0;
             ArrayList<CharSequence> repoErrors = new ArrayList<>();
             boolean changes = false;
             boolean singleRepoUpdate = !TextUtils.isEmpty(address);
@@ -362,7 +362,7 @@ public class UpdateService extends IntentService implements ProgressListener {
                     continue;
                 }
                 if (singleRepoUpdate && !repo.address.equals(address)) {
-                    unchangedRepos.add(repo);
+                    unchangedRepos++;
                     continue;
                 }
                 if (!singleRepoUpdate && repo.isSwap) {
@@ -376,13 +376,13 @@ public class UpdateService extends IntentService implements ProgressListener {
                 try {
                     updater.update();
                     if (updater.hasChanged()) {
-                        updatedRepos.add(repo);
+                        updatedRepos++;
                         changes = true;
                     } else {
-                        unchangedRepos.add(repo);
+                        unchangedRepos++;
                     }
                 } catch (RepoUpdater.UpdateException e) {
-                    errorRepos.add(repo.address);
+                    errorRepos++;
                     repoErrors.add(e.getMessage());
                     Log.e(TAG, "Error updating repository " + repo.address, e);
                 }
@@ -403,14 +403,14 @@ public class UpdateService extends IntentService implements ProgressListener {
             e.putLong(Preferences.PREF_UPD_LAST, System.currentTimeMillis());
             e.commit();
 
-            if (errorRepos.isEmpty()) {
+            if (errorRepos == 0) {
                 if (changes) {
                     sendStatus(this, STATUS_COMPLETE_WITH_CHANGES);
                 } else {
                     sendStatus(this, STATUS_COMPLETE_AND_SAME);
                 }
             } else {
-                if (updatedRepos.size() + unchangedRepos.size() == 0) {
+                if (updatedRepos + unchangedRepos == 0) {
                     sendRepoErrorStatus(STATUS_ERROR_LOCAL, repoErrors);
                 } else {
                     sendRepoErrorStatus(STATUS_ERROR_LOCAL_SMALL, repoErrors);