Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RootInstaller: Put quotes around filenames and package names

Browse Source
This commit is contained in:
Dominik Schürmann 2015-01-19 15:48:39 +01:00 committed by Hans-Christoph Steiner
parent 521218a45c
commit 1f2fe25cd4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
F-Droid/src/org/fdroid/fdroid/installer/RootInstaller.java
View File

@ -130,7 +130,7 @@ public class RootInstaller extends Installer {
} }
private void addInstallCommand(File apkFile) { private void addInstallCommand(File apkFile) {
rootSession.addCommand("pm install -r " + apkFile.getAbsolutePath(), 0, rootSession.addCommand("pm install -r \"" + apkFile.getAbsolutePath() + "\"", 0,
new Shell.OnCommandResultListener() { new Shell.OnCommandResultListener() {
public void onCommandResult(int commandCode, int exitCode, List<String> output) { public void onCommandResult(int commandCode, int exitCode, List<String> output) {
// close su shell // close su shell
@ -151,7 +151,7 @@ public class RootInstaller extends Installer {
List<String> commands = new ArrayList<String>(); List<String> commands = new ArrayList<String>();
String pm = "pm install -r "; String pm = "pm install -r ";
for (File apkFile : apkFiles) { for (File apkFile : apkFiles) {
commands.add(pm + apkFile.getAbsolutePath()); commands.add(pm + "\"" + apkFile.getAbsolutePath() + "\"");
} }
rootSession.addCommand(commands, 0, rootSession.addCommand(commands, 0,
@ -174,7 +174,7 @@ public class RootInstaller extends Installer {
} }
private void addDeleteCommand(String packageName) { private void addDeleteCommand(String packageName) {
rootSession.addCommand("pm uninstall " + packageName, 0, rootSession.addCommand("pm uninstall \"" + packageName + "\"", 0,
new Shell.OnCommandResultListener() { new Shell.OnCommandResultListener() {
public void onCommandResult(int commandCode, int exitCode, List<String> output) { public void onCommandResult(int commandCode, int exitCode, List<String> output) {
// close su shell // close su shell