only show "Install History" Setting when it is actually enabled

This commit is contained in:
Hans-Christoph Steiner 2018-07-17 15:59:29 +02:00
parent 1771f2ce9f
commit 1cb9754545

View File

@ -101,6 +101,8 @@ public class PreferencesFragment extends PreferenceFragment
private SwitchPreference useTorCheckPref; private SwitchPreference useTorCheckPref;
private Preference updateAutoDownloadPref; private Preference updateAutoDownloadPref;
private Preference updatePrivilegedExtensionPref; private Preference updatePrivilegedExtensionPref;
private CheckBoxPreference keepInstallHistoryPref;
private Preference installHistoryPref;
private long currentKeepCacheTime; private long currentKeepCacheTime;
private int overWifiPrevious; private int overWifiPrevious;
private int overDataPrevious; private int overDataPrevious;
@ -114,6 +116,10 @@ public class PreferencesFragment extends PreferenceFragment
addPreferencesFromResource(R.xml.preferences); addPreferencesFromResource(R.xml.preferences);
otherPrefGroup = (PreferenceGroup) findPreference("pref_category_other"); otherPrefGroup = (PreferenceGroup) findPreference("pref_category_other");
keepInstallHistoryPref = (CheckBoxPreference) findPreference(Preferences.PREF_KEEP_INSTALL_HISTORY);
installHistoryPref = findPreference("installHistory");
installHistoryPref.setVisible(keepInstallHistoryPref.isChecked());
useTorCheckPref = (SwitchPreference) findPreference(Preferences.PREF_USE_TOR); useTorCheckPref = (SwitchPreference) findPreference(Preferences.PREF_USE_TOR);
enableProxyCheckPref = (SwitchPreference) findPreference(Preferences.PREF_ENABLE_PROXY); enableProxyCheckPref = (SwitchPreference) findPreference(Preferences.PREF_ENABLE_PROXY);
updateAutoDownloadPref = findPreference(Preferences.PREF_AUTO_DOWNLOAD_INSTALL_UPDATES); updateAutoDownloadPref = findPreference(Preferences.PREF_AUTO_DOWNLOAD_INSTALL_UPDATES);
@ -338,14 +344,12 @@ public class PreferencesFragment extends PreferenceFragment
break; break;
case Preferences.PREF_KEEP_INSTALL_HISTORY: case Preferences.PREF_KEEP_INSTALL_HISTORY:
CheckBoxPreference p = (CheckBoxPreference) findPreference(key); if (keepInstallHistoryPref.isChecked()) {
Preference installHistory = findPreference("installHistory");
if (p.isChecked()) {
InstallHistoryService.register(getActivity()); InstallHistoryService.register(getActivity());
installHistory.setVisible(true); installHistoryPref.setVisible(true);
} else { } else {
InstallHistoryService.unregister(getActivity()); InstallHistoryService.unregister(getActivity());
installHistory.setVisible(false); installHistoryPref.setVisible(false);
} }
break; break;
} }