Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disable annoying or erronous PMD errors

Browse Source
This commit is contained in:
Hans-Christoph Steiner 2020-01-02 21:07:06 +01:00
parent c987e6ad4c
commit 1c0957ce77
No known key found for this signature in database
GPG Key ID: 3E177817BA1B9BFA
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/androidTest/java/org/fdroid/fdroid/Netstat.java
View File

@ -123,7 +123,7 @@ public class Netstat {
try { try {
BufferedReader in = new BufferedReader(new FileReader("/proc/net/tcp")); BufferedReader in = new BufferedReader(new FileReader("/proc/net/tcp"));
String line; String line;
while ((line = in.readLine()) != null) { while ((line = in.readLine()) != null) { // NOPMD
Matcher matcher = NET_PATTERN.matcher(line); Matcher matcher = NET_PATTERN.matcher(line);
if (matcher.find()) { if (matcher.find()) {
final Connection c = new Connection(); final Connection c = new Connection();
@ -156,7 +156,7 @@ public class Netstat {
try { try {
BufferedReader in = new BufferedReader(new FileReader("/proc/net/udp")); BufferedReader in = new BufferedReader(new FileReader("/proc/net/udp"));
String line; String line;
while ((line = in.readLine()) != null) { while ((line = in.readLine()) != null) { // NOPMD
Matcher matcher = NET_PATTERN.matcher(line); Matcher matcher = NET_PATTERN.matcher(line);
if (matcher.find()) { if (matcher.find()) {
final Connection c = new Connection(); final Connection c = new Connection();
@ -189,7 +189,7 @@ public class Netstat {
try { try {
BufferedReader in = new BufferedReader(new FileReader("/proc/net/raw")); BufferedReader in = new BufferedReader(new FileReader("/proc/net/raw"));
String line; String line;
while ((line = in.readLine()) != null) { while ((line = in.readLine()) != null) { // NOPMD
Matcher matcher = NET_PATTERN.matcher(line); Matcher matcher = NET_PATTERN.matcher(line);
if (matcher.find()) { if (matcher.find()) {
final Connection c = new Connection(); final Connection c = new Connection();

2
app/src/main/java/org/fdroid/fdroid/Hasher.java
View File

@ -68,7 +68,7 @@ public class Hasher {
InputStream input = null; InputStream input = null;
try { try {
input = new BufferedInputStream(new FileInputStream(file)); input = new BufferedInputStream(new FileInputStream(file));
while ((read = input.read(buffer)) > 0) { while ((read = input.read(buffer)) > 0) { // NOPMD Avoid assignments in operands
digest.update(buffer, 0, read); digest.update(buffer, 0, read);
} }
} catch (Exception e) { } catch (Exception e) {

2
app/src/main/java/org/fdroid/fdroid/Provisioner.java
View File

@ -173,7 +173,7 @@ public class Provisioner {
try { try {
in = new ZipInputStream(new FileInputStream(file)); in = new ZipInputStream(new FileInputStream(file));
ZipEntry zipEntry; ZipEntry zipEntry;
while ((zipEntry = in.getNextEntry()) != null) { while ((zipEntry = in.getNextEntry()) != null) { // NOPMD Avoid assignments in operands
String name = zipEntry.getName(); String name = zipEntry.getName();
if ("repo_provision.json".equals(name)) { if ("repo_provision.json".equals(name)) {
if (plain.getRepositoryProvision() != null) { if (plain.getRepositoryProvision() != null) {

2
app/src/main/java/org/fdroid/fdroid/Utils.java
View File

@ -524,7 +524,7 @@ public final class Utils {
byte[] dataBytes = new byte[8192]; byte[] dataBytes = new byte[8192];
int nread; int nread;
while ((nread = bis.read(dataBytes)) != -1) { while ((nread = bis.read(dataBytes)) != -1) { // NOPMD Avoid assignments in operands
md.update(dataBytes, 0, nread); md.update(dataBytes, 0, nread);
} }

2
app/src/main/java/org/fdroid/fdroid/views/updates/items/AppUpdateData.java
View File

@ -9,7 +9,7 @@ import android.app.Activity;
* org.fdroid.fdroid.views.updates.UpdatesAdapter#delegatesManager} * org.fdroid.fdroid.views.updates.UpdatesAdapter#delegatesManager}
* to specify a data type more specific than just {@link Object}. * to specify a data type more specific than just {@link Object}.
*/ */
public abstract class AppUpdateData { public abstract class AppUpdateData { // NOPMD This abstract class does not have any abstract methods
public final Activity activity; public final Activity activity;
public AppUpdateData(Activity activity) { public AppUpdateData(Activity activity) {

2
app/src/test/java/org/fdroid/fdroid/data/FDroidProviderTest.java
View File

@ -9,7 +9,7 @@ import org.robolectric.RuntimeEnvironment;
import org.robolectric.Shadows; import org.robolectric.Shadows;
import org.robolectric.shadows.ShadowContentResolver; import org.robolectric.shadows.ShadowContentResolver;
public abstract class FDroidProviderTest { public abstract class FDroidProviderTest { // NOPMD This abstract class does not have any abstract methods
protected ShadowContentResolver contentResolver; protected ShadowContentResolver contentResolver;
protected ContextWrapper context; protected ContextWrapper context;