diff --git a/res/layout/appinfo.xml b/res/layout/appinfo.xml index ce5f42d2a..7a431a861 100644 --- a/res/layout/appinfo.xml +++ b/res/layout/appinfo.xml @@ -29,10 +29,19 @@ android:textSize="12sp" /> + + - - - - diff --git a/res/values/strings.xml b/res/values/strings.xml index 136432f8a..114038e35 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -98,27 +98,10 @@ Downloaded file is corrupt Download cancelled - Anti-Features - This application has the following anti-features: - - Advertising - Show apps that contain advertising This app contains advertising - - Tracking - Show apps that track and report your activity This app tracks and reports your activity - - Add-ons - Show apps that promote non-free add-ons This app promotes non-free add-ons - - Network Services - Show apps that promote non-free network services This app promotes non-free network services - - Dependencies - Show apps that depend on other non-free apps This app depends on other non-free apps Display diff --git a/res/xml/preferences.xml b/res/xml/preferences.xml index d3a39c021..f755058ef 100644 --- a/res/xml/preferences.xml +++ b/res/xml/preferences.xml @@ -24,23 +24,6 @@ android:defaultValue="false" android:summary="@string/compactlayout_long" android:key="compactlayout"/> - - - - - - - "+titleAntiFeature(af)+": "+descAntiFeature(af)+""); - Spanned afs = Html.fromHtml(sb.toString(), null, new HtmlTagHandler()); - tv.setText(afs.subSequence(0, afs.length() - 2)); + sb.append("\t• " + descAntiFeature(af) + "\n"); + sb.setLength(sb.length() - 1); + tv.setText(sb.toString()); } else { - infoView.findViewById(R.id.antifeatures).setVisibility(View.GONE); - infoView.findViewById(R.id.antifeatures_list).setVisibility(View.GONE); + tv.setVisibility(View.GONE); } } - private String titleAntiFeature(String af) { - if (af.equals("Ads")) { - if (!pref_antiAds) return ""+af+""; - return ""+af+""; - } if (af.equals("Tracking")) { - if (pref_antiTracking) return ""+af+""; - return ""+af+""; - } if (af.equals("NonFreeNet")) { - if (pref_antiNonFreeNet) return ""+af+""; - return ""+af+""; - } if (af.equals("NonFreeAdd")) { - if (pref_antiNonFreeAdd) return ""+af+""; - return ""+af+""; - } if (af.equals("NonFreeDep")) { - if (pref_antiNonFreeDep) return ""+af+""; - return ""+af+""; - } return ""; - } - private String descAntiFeature(String af) { if (af.equals("Ads")) return getString(R.string.antiadslist); @@ -586,10 +553,8 @@ public class AppDetails extends ListActivity { private void updateViews() { // Refresh the list... - if (!app.filtered) { - ApkListAdapter la = (ApkListAdapter) getListAdapter(); - la.notifyDataSetChanged(); - } + ApkListAdapter la = (ApkListAdapter) getListAdapter(); + la.notifyDataSetChanged(); TextView tv = (TextView) findViewById(R.id.status); if (app.installedVersion == null) diff --git a/src/org/fdroid/fdroid/AppFilter.java b/src/org/fdroid/fdroid/AppFilter.java index 63940424f..c6be1d372 100644 --- a/src/org/fdroid/fdroid/AppFilter.java +++ b/src/org/fdroid/fdroid/AppFilter.java @@ -24,11 +24,6 @@ import android.preference.PreferenceManager; public class AppFilter { - boolean pref_antiAds; - boolean pref_antiTracking; - boolean pref_antiNonFreeAdd; - boolean pref_antiNonFreeNet; - boolean pref_antiNonFreeDep; boolean pref_rooted; public AppFilter(Context ctx) { @@ -36,11 +31,6 @@ public class AppFilter { // Read preferences and cache them so we can do quick lookups. SharedPreferences prefs = PreferenceManager .getDefaultSharedPreferences(ctx); - pref_antiAds = prefs.getBoolean("antiAds", false); - pref_antiTracking = prefs.getBoolean("antiTracking", false); - pref_antiNonFreeAdd = prefs.getBoolean("antiNonFreeAdd", false); - pref_antiNonFreeNet = prefs.getBoolean("antiNonFreeNet", false); - pref_antiNonFreeDep = prefs.getBoolean("antiNonFreeDep", false); pref_rooted = prefs.getBoolean("rooted", true); } @@ -48,20 +38,6 @@ public class AppFilter { // preferences, and false otherwise. public boolean filter(DB.App app) { boolean filtered = false; - if (app.antiFeatures != null) { - for (String af : app.antiFeatures) { - if (af.equals("Ads") && !pref_antiAds) - filtered = true; - else if (af.equals("Tracking") && !pref_antiTracking) - filtered = true; - else if (af.equals("NonFreeNet") && !pref_antiNonFreeNet) - filtered = true; - else if (af.equals("NonFreeAdd") && !pref_antiNonFreeAdd) - filtered = true; - else if (af.equals("NonFreeDep") && !pref_antiNonFreeDep) - filtered = true; - } - } if (app.requirements != null) { for (String r : app.requirements) { if (r.equals("root") && !pref_rooted)