From 18ae6e6da23e21ab451a4189bd0463a412863392 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Sun, 26 May 2013 12:25:46 +0200
Subject: [PATCH] Refactor about screen.

* Add paddings.
* Don't use hard-coded pixel sizes.
* Don't use white color directly (this would soon break the white holo theme)
* Don't use an "empty" textview to force a vertical space.

Looks much cleaner now, and the code is easier on the eyes.
---
 res/layout/about.xml   | 65 +++++++++++++++++++++++++++---------------
 res/values/strings.xml |  1 -
 2 files changed, 42 insertions(+), 24 deletions(-)

diff --git a/res/layout/about.xml b/res/layout/about.xml
index d8403f176..f9ba30dbe 100644
--- a/res/layout/about.xml
+++ b/res/layout/about.xml
@@ -1,52 +1,71 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-	android:layout_width="fill_parent" android:layout_height="fill_parent"
-	android:orientation="vertical" android:paddingLeft="5px">
+    android:layout_width="fill_parent"
+    android:layout_height="fill_parent"
+    android:paddingLeft="8dp"
+    android:paddingRight="8dp"
+    android:paddingTop="6dp"
+    android:paddingBottom="6dp"
+    android:orientation="vertical">
 
 	<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-		android:layout_width="fill_parent" android:layout_height="fill_parent"
+        android:layout_width="fill_parent"
+        android:layout_height="fill_parent"
 		android:orientation="horizontal">
 
 		<TextView android:text="@string/about_version"
-			android:layout_width="wrap_content" android:layout_height="wrap_content"
-			android:textSize="16px" android:textColor="#ffffff" />
+            android:textStyle="bold"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content" />
 
-		<TextView android:id="@+id/version" android:layout_width="wrap_content"
+        <TextView android:id="@+id/version"
+            android:paddingLeft="5dp"
+            android:layout_width="wrap_content"
 			android:layout_height="wrap_content" />
 
 	</LinearLayout>
 
 	<LinearLayout android:layout_width="fill_parent"
-		android:layout_height="fill_parent" android:orientation="horizontal">
+        android:layout_height="fill_parent"
+        android:orientation="horizontal">
 
-		<TextView android:id="@+id/site" android:text="@string/about_site"
-			android:layout_width="wrap_content" android:layout_height="wrap_content"
-			android:textSize="16px" android:textColor="#ffffff" />
+        <TextView android:id="@+id/site"
+            android:text="@string/about_site"
+            android:textStyle="bold"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content" />
 
-		<TextView android:id="@+id/sitec" android:text="@string/about_sitec"
-			android:layout_width="wrap_content" android:layout_height="wrap_content" />
+        <TextView android:id="@+id/sitec"
+            android:text="@string/about_sitec"
+            android:paddingLeft="5dp"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content" />
 
 	</LinearLayout>
 
 	<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-		android:layout_width="fill_parent" android:layout_height="fill_parent"
+        android:layout_width="fill_parent"
+        android:layout_height="fill_parent"
 		android:orientation="horizontal">
 
-		<TextView android:id="@+id/mail" android:text="@string/about_mail"
-			android:layout_width="wrap_content" android:layout_height="wrap_content"
-			android:textSize="16px" android:textColor="#ffffff" />
+        <TextView android:id="@+id/mail"
+            android:text="@string/about_mail"
+            android:textStyle="bold"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content" />
 
-		<TextView android:id="@+id/mailc" android:text="@string/about_mailc"
-			android:autoLink="email" android:layout_width="wrap_content"
+        <TextView android:id="@+id/mailc"
+            android:text="@string/about_mailc"
+            android:paddingLeft="5dp"
+            android:autoLink="email"
+            android:layout_width="wrap_content"
 			android:layout_height="wrap_content" />
 
 	</LinearLayout>
 
-	<TextView android:id="@+id/not" android:text="@string/about_not"
-		android:layout_width="wrap_content" android:layout_height="wrap_content" />
-
 	<TextView android:text="@string/about_desc"
-		android:layout_width="fill_parent" android:layout_height="fill_parent"
-		android:textSize="16px" />
+        android:paddingTop="5dp"
+        android:layout_width="fill_parent"
+        android:layout_height="fill_parent" />
 
 </LinearLayout>
diff --git a/res/values/strings.xml b/res/values/strings.xml
index 24e579438..7b1b70f49 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -36,7 +36,6 @@
 	<string name="about_mailc">admin@f-droid.org</string>
 	<string name="about_version">Version: </string>
 	<string name="about_website">Website</string>
-	<string name="about_not"> </string>
 
 	<string name="no_repo">You don\'t have any repositories configured!\n\nA
 		repository is a source of applications. To add one, press the MENU