diff --git a/app/src/androidTest/java/org/fdroid/fdroid/AssetUtils.java b/app/src/androidTest/java/org/fdroid/fdroid/AssetUtils.java index 65a299b7d..95e12a021 100644 --- a/app/src/androidTest/java/org/fdroid/fdroid/AssetUtils.java +++ b/app/src/androidTest/java/org/fdroid/fdroid/AssetUtils.java @@ -1,8 +1,8 @@ package org.fdroid.fdroid; import android.content.Context; -import androidx.annotation.Nullable; import android.util.Log; +import androidx.annotation.Nullable; import java.io.File; import java.io.FileOutputStream; @@ -16,6 +16,9 @@ public class AssetUtils { private static final String TAG = "Utils"; + /** + * This requires {@link Context} from {@link android.app.Instrumentation#getContext()} + */ @Nullable public static File copyAssetToDir(Context context, String assetName, File directory) { File tempFile = null; @@ -28,6 +31,7 @@ public class AssetUtils { output = new FileOutputStream(tempFile); Utils.copy(input, output); } catch (IOException e) { + Log.e(TAG, "Check the context is from Instrumentation.getContext()"); fail(e.getMessage()); } finally { Utils.closeQuietly(output); diff --git a/app/src/main/java/org/fdroid/fdroid/data/Apk.java b/app/src/main/java/org/fdroid/fdroid/data/Apk.java index 5d17d68fa..be868e740 100644 --- a/app/src/main/java/org/fdroid/fdroid/data/Apk.java +++ b/app/src/main/java/org/fdroid/fdroid/data/Apk.java @@ -618,6 +618,10 @@ public class Apk extends ValueObject implements Comparable, Parcelable { return new File(this.getMediaInstallPath(context), SanitizedFile.sanitizeFileName(this.apkName)); } + /** + * Check whether a media file is "installed" as based on the file type's + * install path, derived in {@link #getMediaInstallPath(Context)} + */ public boolean isMediaInstalled(Context context) { return getInstalledMediaFile(context).isFile(); }