From 145314a83a5e6bee1c718b8f9747dcb31ec0e336 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Sat, 23 Apr 2016 17:38:42 +0100
Subject: [PATCH] UpdateService: add missing cursor.close()
Found by Android Studio.
---
.../java/org/fdroid/fdroid/UpdateService.java | 21 +++++++++++--------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/app/src/main/java/org/fdroid/fdroid/UpdateService.java b/app/src/main/java/org/fdroid/fdroid/UpdateService.java
index a9a631a4a..67318670e 100644
--- a/app/src/main/java/org/fdroid/fdroid/UpdateService.java
+++ b/app/src/main/java/org/fdroid/fdroid/UpdateService.java
@@ -489,15 +489,18 @@ public class UpdateService extends IntentService implements ProgressListener {
AppProvider.DataColumns.PACKAGE_NAME,
AppProvider.DataColumns.SUGGESTED_VERSION_CODE,
}, null, null, null);
- cursor.moveToFirst();
- for (int i = 0; i < cursor.getCount(); i++) {
- App app = new App(cursor);
- Apk apk = ApkProvider.Helper.find(this, app.packageName, app.suggestedVersionCode, new String[]{
- ApkProvider.DataColumns.NAME,
- });
- String urlString = Utils.getApkUrl(repoAddress, apk);
- DownloaderService.queue(this, app.packageName, urlString);
- cursor.moveToNext();
+ if (cursor != null) {
+ cursor.moveToFirst();
+ for (int i = 0; i < cursor.getCount(); i++) {
+ App app = new App(cursor);
+ Apk apk = ApkProvider.Helper.find(this, app.packageName, app.suggestedVersionCode, new String[]{
+ ApkProvider.DataColumns.NAME,
+ });
+ String urlString = Utils.getApkUrl(repoAddress, apk);
+ DownloaderService.queue(this, app.packageName, urlString);
+ cursor.moveToNext();
+ }
+ cursor.close();
}
}