Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

make sure HTTP servers are able to skip the right amount

Browse Source 
This should fix the PMD error:
"Check the value returned by the skip() method of an InputStream to see if
the requested number of bytes has been skipped."
This commit is contained in:
Hans-Christoph Steiner 2016-05-11 16:39:40 +02:00
parent a0c20a35c3
commit 103b2265ee
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/org/fdroid/fdroid/net/LocalHTTPD.java
View File

@ -265,7 +265,10 @@ public class LocalHTTPD extends NanoHTTPD {
return (int) dataLen; return (int) dataLen;
} }
}; };
fis.skip(startFrom); long skipped = fis.skip(startFrom);
if (skipped != startFrom) {
throw new IOException("unable to skip the required " + startFrom + " bytes.");
}
res = createResponse(Response.Status.PARTIAL_CONTENT, mime, fis); res = createResponse(Response.Status.PARTIAL_CONTENT, mime, fis);
res.addHeader("Content-Length", String.valueOf(dataLen)); res.addHeader("Content-Length", String.valueOf(dataLen));

5
app/src/main/java/org/fdroid/fdroid/net/bluetooth/BluetoothServer.java
View File

@ -303,7 +303,10 @@ public class BluetoothServer extends Thread {
return (int) dataLen; return (int) dataLen;
} }
}; };
fis.skip(startFrom); long skipped = fis.skip(startFrom);
if (skipped != startFrom) {
throw new IOException("unable to skip the required " + startFrom + " bytes.");
}
res = createResponse(NanoHTTPD.Response.Status.PARTIAL_CONTENT, mime, fis); res = createResponse(NanoHTTPD.Response.Status.PARTIAL_CONTENT, mime, fis);
res.addHeader("Content-Length", String.valueOf(dataLen)); res.addHeader("Content-Length", String.valueOf(dataLen));