From 0efdc9df001fb51b6a2bd8cac82e1f4f35c4fcf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Fri, 3 May 2013 21:29:31 +0200 Subject: [PATCH] Nicer loops. Don't start an iterator if not needed --- src/org/fdroid/fdroid/AppDetails.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java index 5430bedb9..bf26cc4fa 100644 --- a/src/org/fdroid/fdroid/AppDetails.java +++ b/src/org/fdroid/fdroid/AppDetails.java @@ -443,10 +443,11 @@ public class AppDetails extends ListActivity { tv = (TextView) infoView.findViewById(R.id.permissions_list); if (pref_permissions) { CommaSeparatedList permsList = app.apks.get(0).detail_permissions; - Iterator permissions = permsList != null ? permsList.iterator() : null; - if (null != permissions && permissions.hasNext()) { + if (permsList == null) tv.setText("NONE"); + else { + Iterator permissions = permsList.iterator(); StringBuilder sb = new StringBuilder(); - while(permissions.hasNext()) { + while (permissions.hasNext()) { String permissionName = permissions.next(); try { Permission permission = new Permission(this, permissionName); @@ -460,8 +461,6 @@ public class AppDetails extends ListActivity { } } tv.setText(sb.toString()); - } else { - tv.setText("NONE"); } tv = (TextView) infoView.findViewById(R.id.permissions); tv.setText(getResources().getString(