From 0a2cd98bddea03278cdcbee55f5d6e3b57cd5209 Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Sun, 16 Oct 2016 20:52:42 +1100 Subject: [PATCH] Added explicit test for null permissions. This wouldn'tve actually found the problem in the previous commit, due to the null happening before checking permissions while logging perms. However, still seems like a nice test to have so that the method itself handles nulls correctly. --- .../org/fdroid/fdroid/installer/ApkVerifierTest.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/app/src/androidTest/java/org/fdroid/fdroid/installer/ApkVerifierTest.java b/app/src/androidTest/java/org/fdroid/fdroid/installer/ApkVerifierTest.java index 28bfffdea..fabd5649b 100644 --- a/app/src/androidTest/java/org/fdroid/fdroid/installer/ApkVerifierTest.java +++ b/app/src/androidTest/java/org/fdroid/fdroid/installer/ApkVerifierTest.java @@ -99,6 +99,15 @@ public class ApkVerifierTest { assertTrue(extendedPermsXml.exists()); } + @Test + public void testNulls() { + assertTrue(ApkVerifier.requestedPermissionsEqual(null, null)); + + String[] perms = new String[] {"Blah"}; + assertFalse(ApkVerifier.requestedPermissionsEqual(perms, null)); + assertFalse(ApkVerifier.requestedPermissionsEqual(null, perms)); + } + @Test public void testWithoutPrefix() { Apk apk = new Apk();