From 080bab482d24028712d62a325598b7eb65d256fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Sun, 10 Nov 2013 18:52:34 +0100 Subject: [PATCH] Fix possible crashes when entering AppDetails --- src/org/fdroid/fdroid/AppDetails.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java index 0c30a287c..445e3cd29 100644 --- a/src/org/fdroid/fdroid/AppDetails.java +++ b/src/org/fdroid/fdroid/AppDetails.java @@ -502,13 +502,15 @@ public class AppDetails extends ListActivity { Permission permission = new Permission(this, permissionName); sb.append("\t• " + permission.getName() + '\n'); } catch (NameNotFoundException e) { - if (permissionName.equals("ACCESS_SUPERUSER")) + if (permissionName.equals("ACCESS_SUPERUSER")) { sb.append("\t• Full permissions to all device features and storage\n"); - else - Log.d("FDroid", "Can't find permission "+permissionName); + } else { + Log.d("FDroid", "Permission not yet available: " + +permissionName); + } } } - sb.setLength(sb.length() - 1); + if (sb.length() > 0) sb.setLength(sb.length() - 1); tv.setText(sb.toString()); } tv = (TextView) infoView.findViewById(R.id.permissions); @@ -524,7 +526,7 @@ public class AppDetails extends ListActivity { StringBuilder sb = new StringBuilder(); for (String af : app.antiFeatures) sb.append("\t• " + descAntiFeature(af) + "\n"); - sb.setLength(sb.length() - 1); + if (sb.length() > 0) sb.setLength(sb.length() - 1); tv.setText(sb.toString()); } else { tv.setVisibility(View.GONE);