From 079cf2e903ce8eb57446663ba46cd4d6003ae4b2 Mon Sep 17 00:00:00 2001
From: Hans-Christoph Steiner <hans@eds.org>
Date: Mon, 31 Dec 2018 22:14:10 +0100
Subject: [PATCH] enable lint HardwareIds as error

Keep PRNGFixes as it is since it is security sensitive, standardized
code from Google.  While F-Droid never wants to do anything with
hardware IDs at all, this code uses the Build.SERIAL as a seed for the
random number generator, so it is safe privacy-wise.
---
 app/lint.xml                                              | 1 +
 app/src/main/java/org/fdroid/fdroid/compat/PRNGFixes.java | 1 +
 2 files changed, 2 insertions(+)

diff --git a/app/lint.xml b/app/lint.xml
index 6dc64ef81..9b706ddf7 100644
--- a/app/lint.xml
+++ b/app/lint.xml
@@ -29,6 +29,7 @@
     <issue id="UnsafeProtectedBroadcastReceiver" severity="error"/>
     <issue id="GetInstance" severity="error"/>
     <issue id="PackageManagerGetSignatures" severity="error"/>
+    <issue id="HardwareIds" severity="error"/>
     <issue id="TrustAllX509TrustManager" severity="error">
       <!-- these come from included libraries -->
         <ignore path="org/apache/commons/net/ftp/FTPSTrustManager.class"/>
diff --git a/app/src/main/java/org/fdroid/fdroid/compat/PRNGFixes.java b/app/src/main/java/org/fdroid/fdroid/compat/PRNGFixes.java
index b9a003e84..a17770f8c 100644
--- a/app/src/main/java/org/fdroid/fdroid/compat/PRNGFixes.java
+++ b/app/src/main/java/org/fdroid/fdroid/compat/PRNGFixes.java
@@ -306,6 +306,7 @@ public final class PRNGFixes {
         }
     }
 
+    @SuppressLint("HardwareIds")
     private static byte[] getBuildFingerprintAndDeviceSerial() {
         StringBuilder result = new StringBuilder();
         String fingerprint = Build.FINGERPRINT;