Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Small optimization in EclairChecker

Browse Source
This commit is contained in:
Henrik Tunedal 2011-03-06 20:50:40 +01:00
parent 1d025c1e7d
commit 06253a94cf
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/org/fdroid/fdroid/DB.java
View File

@ -20,6 +20,7 @@
package org.fdroid.fdroid; package org.fdroid.fdroid;
import java.util.HashMap; import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator; import java.util.Iterator;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
@ -28,6 +29,7 @@ import java.util.Vector;
import android.content.ContentValues; import android.content.ContentValues;
import android.content.Context; import android.content.Context;
import android.content.SharedPreferences; import android.content.SharedPreferences;
import android.content.pm.FeatureInfo;
import android.content.pm.PackageInfo; import android.content.pm.PackageInfo;
import android.content.pm.PackageManager; import android.content.pm.PackageManager;
import android.database.Cursor; import android.database.Cursor;
@ -191,9 +193,13 @@ public class DB {
// Call isCompatible(apk) on an instance of this class to // Call isCompatible(apk) on an instance of this class to
// check if an APK is compatible with the user's device. // check if an APK is compatible with the user's device.
public static abstract class CompatibilityChecker { public static abstract class CompatibilityChecker {
// Because Build.VERSION.SDK_INT requires API level 5 // Because Build.VERSION.SDK_INT requires API level 5
protected final static int SDK_INT protected final static int SDK_INT
= Integer.parseInt(Build.VERSION.SDK); = Integer.parseInt(Build.VERSION.SDK);
public abstract boolean isCompatible(Apk apk);
public static CompatibilityChecker getChecker(Context ctx) { public static CompatibilityChecker getChecker(Context ctx) {
CompatibilityChecker checker; CompatibilityChecker checker;
if (SDK_INT >= 5) if (SDK_INT >= 5)
@ -204,25 +210,32 @@ public class DB {
+ SDK_INT + ": " + checker.getClass().getName()); + SDK_INT + ": " + checker.getClass().getName());
return checker; return checker;
} }
public abstract boolean isCompatible(Apk apk);
} }
private static class BasicChecker extends CompatibilityChecker { private static class BasicChecker extends CompatibilityChecker {
public boolean isCompatible(Apk apk) { public boolean isCompatible(Apk apk) {
return (apk.minSdkVersion <= SDK_INT); return (apk.minSdkVersion <= SDK_INT);
} }
} }
private static class EclairChecker extends CompatibilityChecker { private static class EclairChecker extends CompatibilityChecker {
private PackageManager pm;
private HashSet features;
public EclairChecker(Context ctx) { public EclairChecker(Context ctx) {
pm = ctx.getPackageManager(); PackageManager pm = ctx.getPackageManager();
features = new HashSet();
for (FeatureInfo fi : pm.getSystemAvailableFeatures()) {
features.add(fi.name);
}
} }
public boolean isCompatible(Apk apk) { public boolean isCompatible(Apk apk) {
if (apk.minSdkVersion > SDK_INT) if (apk.minSdkVersion > SDK_INT)
return false; return false;
if (apk.features != null) { if (apk.features != null) {
for (String feat : apk.features) { for (String feat : apk.features) {
if (!pm.hasSystemFeature(feat)) if (!features.contains(feat)) return false;
return false;
} }
} }
return true; return true;