From 06088e2b35edce813cc8fe2b2f3369af302e7a8d Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Wed, 26 Apr 2017 19:39:11 +1000 Subject: [PATCH] Send acra report about crash we are getting, but don't crash F-Droid --- .../fdroid/fdroid/installer/ApkSignatureVerifier.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/installer/ApkSignatureVerifier.java b/app/src/main/java/org/fdroid/fdroid/installer/ApkSignatureVerifier.java index dd8ecaaa4..fd4a9d789 100644 --- a/app/src/main/java/org/fdroid/fdroid/installer/ApkSignatureVerifier.java +++ b/app/src/main/java/org/fdroid/fdroid/installer/ApkSignatureVerifier.java @@ -24,8 +24,8 @@ import android.content.Context; import android.content.pm.PackageInfo; import android.content.pm.PackageManager; import android.content.pm.Signature; -import android.util.Log; +import org.acra.ACRA; import org.fdroid.fdroid.Utils; import org.spongycastle.util.encoders.Hex; @@ -53,8 +53,11 @@ class ApkSignatureVerifier { public boolean hasFDroidSignature(File apkFile) { if (!apkFile.exists()) { - Log.e(TAG, "Failed to verify that " + apkFile.getName() + " has F-Droid signature, " + - "because " + apkFile.getAbsolutePath() + " does not exist."); + ACRA.getErrorReporter().handleException( + new Exception("Failed to install Privileged Extension, because " + apkFile.getAbsolutePath() + " does not exist."), + false + ); + return false; }