Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'focusable' into 'master'

Browse Source 
Add missing "focusable" attributes.

See merge request fdroid/fdroidclient!735
This commit is contained in:
Hans-Christoph Steiner 2018-08-30 20:33:20 +00:00
commit 054bdb5cd4
6 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/res/layout/app_card_horizontal.xml
View File

@ -5,7 +5,8 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:foreground="?attr/selectableItemBackground" android:foreground="?attr/selectableItemBackground"
android:clickable="true"> android:clickable="true"
android:focusable="true">
<android.support.constraint.ConstraintLayout <android.support.constraint.ConstraintLayout
android:layout_width="match_parent" android:layout_width="match_parent"

3
app/src/main/res/layout/app_card_large.xml
View File

@ -5,7 +5,8 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="220dp" android:layout_height="220dp"
android:foreground="?attr/selectableItemBackground" android:foreground="?attr/selectableItemBackground"
android:clickable="true"> android:clickable="true"
android:focusable="true">
<android.support.constraint.ConstraintLayout <android.support.constraint.ConstraintLayout
android:layout_width="match_parent" android:layout_width="match_parent"

3
app/src/main/res/layout/app_card_list_item.xml
View File

@ -5,7 +5,8 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:foreground="?attr/selectableItemBackground" android:foreground="?attr/selectableItemBackground"
android:clickable="true"> android:clickable="true"
android:focusable="true">
<android.support.constraint.ConstraintLayout <android.support.constraint.ConstraintLayout
android:layout_width="match_parent" android:layout_width="match_parent"

3
app/src/main/res/layout/app_details2_links.xml
View File

@ -12,7 +12,8 @@
android:layout_marginBottom="@dimen/details_activity__collapsable_lists__padding__vertical" android:layout_marginBottom="@dimen/details_activity__collapsable_lists__padding__vertical"
android:clickable="true" android:clickable="true"
android:orientation="vertical" android:orientation="vertical"
tools:ignore="UnusedAttribute"> tools:ignore="UnusedAttribute"
android:focusable="true">
<!-- This frame layout is only for showing the material-design-like background ripple when <!-- This frame layout is only for showing the material-design-like background ripple when
selecting the TextView. --> selecting the TextView. -->

3
app/src/main/res/layout/app_list_item.xml
View File

@ -6,7 +6,8 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:clickable="true" android:clickable="true"
android:background="?attr/selectableItemBackground"> android:background="?attr/selectableItemBackground"
android:focusable="true">
<!-- Ignore ContentDescription because it is kind of meaningless to have TTS read out "App icon" <!-- Ignore ContentDescription because it is kind of meaningless to have TTS read out "App icon"
when it will inevitably read out the name of the app straight after. --> when it will inevitably read out the name of the app straight after. -->

3
app/src/main/res/layout/installed_app_list_item.xml
View File

@ -9,7 +9,8 @@
android:paddingTop="8dp" android:paddingTop="8dp"
android:paddingBottom="8dp" android:paddingBottom="8dp"
android:clickable="true" android:clickable="true"
android:background="?attr/selectableItemBackground"> android:background="?attr/selectableItemBackground"
android:focusable="true">
<!-- Ignore ContentDescription because it is kind of meaningless to have TTS read out "App icon" <!-- Ignore ContentDescription because it is kind of meaningless to have TTS read out "App icon"
when it will inevitably read out the name of the app straight after. --> when it will inevitably read out the name of the app straight after. -->