Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PMD: Enable some extra boolean/logic rules

Browse Source
This commit is contained in:
Daniel Martí 2016-04-28 18:16:05 +01:00
parent ac8d3ff600
commit 023a6d01bd
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/fdroid/fdroid/AppFilter.java
View File

@ -29,12 +29,8 @@ public class AppFilter {
return false; return false;
} }
if (!Preferences.get().filterAppsRequiringRoot() && return !Preferences.get().filterAppsRequiringRoot()
app.requirements.contains("root")) { && app.requirements.contains("root");
return true;
}
return false;
} }
} }

4
config/pmd/rules.xml
View File

@ -39,4 +39,8 @@
<rule ref="rulesets/java/design.xml/IdempotentOperations"/> <rule ref="rulesets/java/design.xml/IdempotentOperations"/>
<rule ref="rulesets/java/design.xml/ImmutableField"/> <rule ref="rulesets/java/design.xml/ImmutableField"/>
<rule ref="rulesets/java/design.xml/SingularField"/> <rule ref="rulesets/java/design.xml/SingularField"/>
<rule ref="rulesets/java/design.xml/SimplifyBooleanReturns"/>
<rule ref="rulesets/java/design.xml/SimplifyBooleanExpressions"/>
<rule ref="rulesets/java/design.xml/LogicInversion"/>
</ruleset> </ruleset>