From 00c138e42fbb52535378d54e1ba2cb5cd2b019b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Sun, 17 Apr 2016 11:39:00 +0100 Subject: [PATCH] PMD: enable and obey java-unusedcode --- app/build.gradle | 2 +- app/src/main/java/org/fdroid/fdroid/AndroidXMLDecompress.java | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 51dc677df..b680dcd98 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -210,7 +210,7 @@ pmd { task pmd(type: Pmd, dependsOn: assembleDebug) { ruleSets = [ //'java-basic', - //'java-unusedcode', + 'java-unusedcode', 'java-android', 'java-clone', 'java-finalizers', diff --git a/app/src/main/java/org/fdroid/fdroid/AndroidXMLDecompress.java b/app/src/main/java/org/fdroid/fdroid/AndroidXMLDecompress.java index b8569f246..c801106ca 100644 --- a/app/src/main/java/org/fdroid/fdroid/AndroidXMLDecompress.java +++ b/app/src/main/java/org/fdroid/fdroid/AndroidXMLDecompress.java @@ -91,7 +91,6 @@ public class AndroidXMLDecompress { while (offset < binaryXml.length) { int tag0 = littleEndianWord(binaryXml, offset); - int nameStringIndex = littleEndianWord(binaryXml, offset + 5 * 4); if (tag0 == startTag) { int numbAttrs = littleEndianWord(binaryXml, offset + 7 * 4);